BHelpful / MomentMeal

MomentMeal is a marketplace for food and recipes. We help you find and create the best recipes and meal plans for you.
https://momentmeal.com/
GNU Affero General Public License v3.0
13 stars 5 forks source link

Add field component #436

Closed Andreasgdp closed 1 year ago

Andreasgdp commented 1 year ago

Purpose/Approach

Solves #438 Adds field component (design) and simple icon capability for button

NOTE: multiline functionality of field is not implemented.

image image image

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 78216c53c7f89c67d6671b7fbd9222181be4c992. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets - [`nx affected --target=build --base=origin/master --parallel`](https://cloud.nx.app/runs/0yzQR9O7zTB) - [`nx affected --target=lint --base=origin/master --parallel`](https://cloud.nx.app/runs/JqbO2dwNKpL)

Sent with 💌 from NxCloud.

gitguardian[bot] commented 1 year ago

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them. Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately. Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Andreasgdp commented 1 year ago

I think the error handling for password could be more descriptive, no idea what is wrong: https://i.imgur.com/IetefoO.png

The email does not check "correctly" for emails it accepts i.e. "d@d", need some regex for . https://i.imgur.com/7zzx2RN.png

Technically"d@d" is a valid email but in practice it is not really valid. Fortunately these changes has nothing to do with the Field component itself, but the implementation of the component in auth page.

I'll create a custom validator for the email and a custom validator for the password pattern.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Andreasgdp commented 1 year ago

Looked at the code it seems fine, i have not tested it yet due to the fact that I cannot run make db due to 2 seperate errors:

  1. build.mk file the COMPOSE_DOCKER_CLI_BUILD=1 DOCKER_BUILDKIT=1 is not recognised, can run if removed - but do not know if it changes behavior
  2. docker-compose.yml: the port has to be a number it is a string

I would suggest updating the HOW_TO if theres is anything I am missing to run the app

  1. As now described in getting started: you (for now) need to run the make commands in bash.
  2. Don't know why you are getting that error. Try running yarn gen:env then run the commands in bash as mentioned above. Else we will have to take a look at it together @Toeffe3.
Andreasgdp commented 1 year ago

That should have addressed all requested changes :)