BHelpful / MomentMeal

MomentMeal is a marketplace for food and recipes. We help you find and create the best recipes and meal plans for you.
https://momentmeal.com/
GNU Affero General Public License v3.0
13 stars 5 forks source link

388 minor implement the missing crud operations of stores model api #437

Closed BareMaxx closed 2 years ago

BareMaxx commented 2 years ago

Purpose/Approach

This closes #388

Testing steps to find bugs or errors in added code.

Run yarn test --watch and see that all tests pass

nx-cloud[bot] commented 2 years ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e001389c2c34807bf4f734287fe3de63f89a3a3d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets - [`nx affected --target=build --base=origin/master --parallel`](https://cloud.nx.app/runs/FhaWtQUaxbF) - [`nx affected --target=lint --base=origin/master --parallel`](https://cloud.nx.app/runs/fHlCHoborLl)

Sent with 💌 from NxCloud.

gitguardian[bot] commented 2 years ago

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [4285856](https://dashboard.gitguardian.com/incidents/4285856?occurrence=54934268) | Generic High Entropy Secret | 4ee553e15e3ae939bedbadced2a16a1e2fd3f297 | nx.json | [View secret](https://github.com/BHelpful/MealTime/commit/4ee553e15e3ae939bedbadced2a16a1e2fd3f297#diff-15552e50b1b7c05b05b7ffe08ee47b5ed62b8d2039229c58972a42fd22a7381cL22) | | [4285856](https://dashboard.gitguardian.com/incidents/4285856?occurrence=54934269) | Generic High Entropy Secret | 4ee553e15e3ae939bedbadced2a16a1e2fd3f297 | nx.json | [View secret](https://github.com/BHelpful/MealTime/commit/4ee553e15e3ae939bedbadced2a16a1e2fd3f297#diff-15552e50b1b7c05b05b7ffe08ee47b5ed62b8d2039229c58972a42fd22a7381cR22) | | [4285856](https://dashboard.gitguardian.com/incidents/4285856?occurrence=55036481) | Generic High Entropy Secret | aae1b14a075c2b5693448c05eb032ecf37592381 | nx.json | [View secret](https://github.com/BHelpful/MealTime/commit/aae1b14a075c2b5693448c05eb032ecf37592381#diff-15552e50b1b7c05b05b7ffe08ee47b5ed62b8d2039229c58972a42fd22a7381cL22) | | [4285856](https://dashboard.gitguardian.com/incidents/4285856?occurrence=55036482) | Generic High Entropy Secret | aae1b14a075c2b5693448c05eb032ecf37592381 | nx.json | [View secret](https://github.com/BHelpful/MealTime/commit/aae1b14a075c2b5693448c05eb032ecf37592381#diff-15552e50b1b7c05b05b7ffe08ee47b5ed62b8d2039229c58972a42fd22a7381cR22) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication