BHelpful / MomentMeal

MomentMeal is a marketplace for food and recipes. We help you find and create the best recipes and meal plans for you.
https://momentmeal.com/
GNU Affero General Public License v3.0
13 stars 5 forks source link

Reduce complexity of stores service #530

Closed Andreasgdp closed 1 year ago

Andreasgdp commented 1 year ago

Purpose/Approach

Reduce complexity as mentioned here https://codescene.io/projects/27963/jobs/634504/results/code/hotspots/biomarkers?name=MealTime%2Fapps%2Fapi%2Fsrc%2Fmodules%2Fstores%2Fstores.service.ts

Tests has been run locally and passes.

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f7c3a93b187a731ef163cdea9b908ceab8dd0ecb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets - [`nx affected --target=lint --base=origin/master --parallel`](https://cloud.nx.app/runs/VEtK3Lq21yu) - [`nx affected --target=build --base=origin/master --parallel`](https://cloud.nx.app/runs/vyEy9n84KCA)

Sent with 💌 from NxCloud.

Andreasgdp commented 1 year ago

It can be seen from the changes of this PR that the issue is fixed image

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication