Andreasgdp commented 1 year ago

Purpose/Approach

Solve #551

This PR also featuresthe following

Changes to setup and usage after removing SuperTokens
- E.g., we no longer use make, instead I have introduced a couple of commands in the package.json like yarn db:reset to setup a clean database in docker.
Setup of .spec files of new auth system to make it easier to implement tests of them later.
All current tests as part of CircleCI pipeline.

At a later point we can go over and:

@Toeffe3 We will need to make some minor changes to the prisma schema, as the database needs to be mysql for us to be able to use PlanetScale. Prisma is equipped to handle this see example use in another project of mine. We will just have to make the right adjustments so it works in our setup.
Implement social auth like in the example here
Implement actual tests of auth in backend and frontend
Implement missing features of auth e.g., forgot password, password change ...
Want to go over the api implementing auth guards for user's recipes, as it is theirs, but also for public recipes using our to be created own api tokens
Consider the switch from CircleCI to just GitHub Actions for more coherent contributor experience. For now I think it is important, that we can now again test PRs to make reviews in general easier.

Testing steps to find bugs or errors in added code.

[x] Sign up with a user
[x] Sign out
[x] Sign in with that user
[x] See that protected routes are only accessible when signed in

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 94260bd208e1625a893b658a365807ee5cbb660b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 3 targets

- [`nx affected --target=test --base=origin/master --parallel --codeCoverage --maxWorkers=1`](https://cloud.nx.app/runs/Mc1aEJ2mso) - [`nx affected --target=build --base=origin/master --parallel`](https://cloud.nx.app/runs/75jLeOg5Eh) - [`nx affected --target=lint --base=origin/master --parallel`](https://cloud.nx.app/runs/kzQnLd17CH)

Sent with 💌 from NxCloud.

stackblitz[bot] commented 1 year ago

Run & review this pull request in StackBlitz Codeflow.

gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [4062480](https://dashboard.gitguardian.com/incidents/4062480?occurrence=86745788) | GitHub OAuth App Keys | d92436cd39b6ce3c05832191bf944a279913c9da | tools/generators/gen-env/files/__template__.env | [View secret](https://github.com/BHelpful/MealTime/commit/d92436cd39b6ce3c05832191bf944a279913c9da#diff-e21c5ec613379138d26f24c1f3a9ef488610c53d76a1d4f6e739162c37a4fb26L19) | | [4062479](https://dashboard.gitguardian.com/incidents/4062479?occurrence=86745787) | Google OAuth2 Keys | d92436cd39b6ce3c05832191bf944a279913c9da | tools/generators/gen-env/files/__template__.env | [View secret](https://github.com/BHelpful/MealTime/commit/d92436cd39b6ce3c05832191bf944a279913c9da#diff-e21c5ec613379138d26f24c1f3a9ef488610c53d76a1d4f6e739162c37a4fb26L16) | | [4062478](https://dashboard.gitguardian.com/incidents/4062478?occurrence=86745789) | Generic Private Key | d92436cd39b6ce3c05832191bf944a279913c9da | tools/generators/gen-env/files/__template__.env | [View secret](https://github.com/BHelpful/MealTime/commit/d92436cd39b6ce3c05832191bf944a279913c9da#diff-e21c5ec613379138d26f24c1f3a9ef488610c53d76a1d4f6e739162c37a4fb26L23) | | [4062480](https://dashboard.gitguardian.com/incidents/4062480?occurrence=86745786) | GitHub OAuth App Keys | d92436cd39b6ce3c05832191bf944a279913c9da | tools/generators/gen-env/files/__template__.env.docker | [View secret](https://github.com/BHelpful/MealTime/commit/d92436cd39b6ce3c05832191bf944a279913c9da#diff-4dde73ea3d10a1dfcfbf4f775623f6c3a79ab8c61cf9f8da52372bdf953e3b0fL19) | | [4062479](https://dashboard.gitguardian.com/incidents/4062479?occurrence=86745785) | Google OAuth2 Keys | d92436cd39b6ce3c05832191bf944a279913c9da | tools/generators/gen-env/files/__template__.env.docker | [View secret](https://github.com/BHelpful/MealTime/commit/d92436cd39b6ce3c05832191bf944a279913c9da#diff-4dde73ea3d10a1dfcfbf4f775623f6c3a79ab8c61cf9f8da52372bdf953e3b0fL16) | | [4062478](https://dashboard.gitguardian.com/incidents/4062478?occurrence=86745784) | Generic Private Key | d92436cd39b6ce3c05832191bf944a279913c9da | tools/generators/gen-env/files/__template__.env.docker | [View secret](https://github.com/BHelpful/MealTime/commit/d92436cd39b6ce3c05832191bf944a279913c9da#diff-4dde73ea3d10a1dfcfbf4f775623f6c3a79ab8c61cf9f8da52372bdf953e3b0fL23) |

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/specifics/github_oauth_app_keys#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}