BHelpful / MomentMeal

MomentMeal is a marketplace for food and recipes. We help you find and create the best recipes and meal plans for you.
https://momentmeal.com/
GNU Affero General Public License v3.0
13 stars 5 forks source link

440 minor backend for categories #557

Closed BareMaxx closed 1 year ago

BareMaxx commented 1 year ago

Purpose/Approach

Testing steps to find bugs or errors in added code.

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3cd7f648d211423f636a11932d44ba3a5dc004ca. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets - [`nx affected --target=build --base=origin/master --parallel`](https://cloud.nx.app/runs/E0C4TNaXm7) - [`nx affected --target=lint --base=origin/master --parallel`](https://cloud.nx.app/runs/16sbozl3gs)

Sent with 💌 from NxCloud.

stackblitz[bot] commented 1 year ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mealtime ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2023 10:19am
mealtime-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2023 10:19am
gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [4062480](https://dashboard.gitguardian.com/incidents/4062480?occurrence=87774994) | GitHub OAuth App Keys | 11ccf8bef3c867098ade8a19485bd0b0f8156a4d | tools/generators/gen-env/files/__template__.env | [View secret](https://github.com/BHelpful/MealTime/commit/11ccf8bef3c867098ade8a19485bd0b0f8156a4d#diff-e21c5ec613379138d26f24c1f3a9ef488610c53d76a1d4f6e739162c37a4fb26L19) | | [4062479](https://dashboard.gitguardian.com/incidents/4062479?occurrence=87774997) | Google OAuth2 Keys | 11ccf8bef3c867098ade8a19485bd0b0f8156a4d | tools/generators/gen-env/files/__template__.env | [View secret](https://github.com/BHelpful/MealTime/commit/11ccf8bef3c867098ade8a19485bd0b0f8156a4d#diff-e21c5ec613379138d26f24c1f3a9ef488610c53d76a1d4f6e739162c37a4fb26L16) | | [4062478](https://dashboard.gitguardian.com/incidents/4062478?occurrence=87774998) | Generic Private Key | 11ccf8bef3c867098ade8a19485bd0b0f8156a4d | tools/generators/gen-env/files/__template__.env | [View secret](https://github.com/BHelpful/MealTime/commit/11ccf8bef3c867098ade8a19485bd0b0f8156a4d#diff-e21c5ec613379138d26f24c1f3a9ef488610c53d76a1d4f6e739162c37a4fb26L23) | | [4062480](https://dashboard.gitguardian.com/incidents/4062480?occurrence=87774993) | GitHub OAuth App Keys | 11ccf8bef3c867098ade8a19485bd0b0f8156a4d | tools/generators/gen-env/files/__template__.env.docker | [View secret](https://github.com/BHelpful/MealTime/commit/11ccf8bef3c867098ade8a19485bd0b0f8156a4d#diff-4dde73ea3d10a1dfcfbf4f775623f6c3a79ab8c61cf9f8da52372bdf953e3b0fL19) | | [4062479](https://dashboard.gitguardian.com/incidents/4062479?occurrence=87774995) | Google OAuth2 Keys | 11ccf8bef3c867098ade8a19485bd0b0f8156a4d | tools/generators/gen-env/files/__template__.env.docker | [View secret](https://github.com/BHelpful/MealTime/commit/11ccf8bef3c867098ade8a19485bd0b0f8156a4d#diff-4dde73ea3d10a1dfcfbf4f775623f6c3a79ab8c61cf9f8da52372bdf953e3b0fL16) | | [4062478](https://dashboard.gitguardian.com/incidents/4062478?occurrence=87774996) | Generic Private Key | 11ccf8bef3c867098ade8a19485bd0b0f8156a4d | tools/generators/gen-env/files/__template__.env.docker | [View secret](https://github.com/BHelpful/MealTime/commit/11ccf8bef3c867098ade8a19485bd0b0f8156a4d#diff-4dde73ea3d10a1dfcfbf4f775623f6c3a79ab8c61cf9f8da52372bdf953e3b0fL23) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/specifics/github_oauth_app_keys#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication