search

BHoM / BHoM

The Buildings and Habitats Core object Model repo
https://bhom.xyz
GNU Lesser General Public License v3.0
226 stars 49 forks source link

MEP-oM: Add Surface Roughness/ Duct Materiality as parameter to duct object #1397

Open travispotterBH opened 2 years ago

travispotterBH commented 2 years ago

Description:

Add surface roughness to duct object as a parameter. Surface roughness is used in duct pressure drop calculations and is a function of the objects materiality.

This could be setup as a simple roughnessFactor parameter, or this could be setup as an Enum for materiality which would then reference a dataset for values. If we opt for the enum/dataset option, we would also probably want to develop a method which checks a duct's box profile and materiality to decide the correct roughnessFactor. See image below for an idea of how they are related.

I am partial to a roughnessFactor parameter, as I believe it is simplest.

@kayleighhoude Thoughts?

0.09 mm roughness factor is common for Galvanized steel in context of SI calculations

image

FraserGreenroyd commented 2 years ago

is a function of the objects materiality

0.09 mm roughness factor is common for Galvanized steel

It sounds to me that these are properties of a material which would be applied to the duct, rather than as a property of the duct itself

travispotterBH commented 1 year ago

Adding material to duct seems fine, need to set a default material for ducts.