search

BHoM / BHoMAnalytics_Toolkit

GNU Lesser General Public License v3.0
1 stars 1 forks source link

Align to changes of Namespace Renaming #3

Closed alelom closed 3 years ago

alelom commented 4 years ago

Broken rules:

Following confirmation here the namespace in this toolkit, for all items except the adapter should have the namespace BH.oM.Adapters.ToolkitName or BH.Engine.Adapters.ToolkitName instead of BH.oM.ToolkitName, etc.

The Adapter namespace should remain at BH.Adapter.ToolkitName instead of BH.Adapter.External.ToolkitName.

➡️ Also This should also align with the changes in dependencies: https://github.com/BHoM/Mongo_Toolkit/pull/120

ALSO make sure that the default namespace is set correctly in the oM and Engine Project properties. ➡️ Right click on the project, navigate to the Application tab, and check the default namespace.

Suggestions to restore compliance:

As above.

adecler commented 4 years ago

@alelom , I will not have time to take care of this for you. Can you do this yourself or assigned to someone else, as it is a pretty straightforward task? Happy to review when done.

alelom commented 4 years ago

@alelom , I will not have time to take care of this for you. Can you do this yourself or assigned to someone else, as it is a pretty straightforward task? Happy to review when done.

Hey @adecler, no worries, you can do it next sprint too. I had to resort in postponing the deadline yet again as everyone is always busy. For now, I'm short on time too, and I've done basically 70% of the other renamings myself, as this keeps on falling on me. I'll reassign you as this is connected to https://github.com/BHoM/Mongo_Toolkit/pull/120 which I also prefer if you could make sure is correctly aligned to this.

adecler commented 4 years ago

Sure, no problem. I'll get both done beginning of next milestone.

adecler commented 3 years ago

There is currently no change needed on this toolkit regarding the namespace. The reason for it is that the Engine methods and oM classes in that repo are local tools not related to the adapter so it doesn't make sense to have them under the adapter namespace.