Read method default implementation for requests only accepts a FilterRequest - Githubissues

BHoM / BHoM_Adapter

GNU Lesser General Public License v3.0

7 stars 6 forks source link

Read method default implementation for requests only accepts a FilterRequest #149

Closed alelom closed 5 years ago

alelom commented 5 years ago

Broken rules:

The Read default implementation for requests only accepts FilterRequests. This is wrong and should accept IRequest instead.

This does not allow for correct implementation of IRequest as happens in e.g. Revit: BHoM/Revit_Toolkit#364

This chains with another issue: Pull does nothing if specified request is not a FilterRequest.

Suggestions to restore compliance:

Implement another Read overload with IRequest as paramter.