BHoM / BHoM_Adapter

GNU Lesser General Public License v3.0

7 stars 6 forks source link

I want to implement an Adapter. What do I need to know / look at? #197

Closed rolyhudson closed 4 years ago

rolyhudson commented 4 years ago

I want to implement an Adapter. What do I need to know / look at?

rwemay commented 4 years ago

dontpanic

What kind of adapter? ;-)

rolyhudson commented 4 years ago

Just for OpenStreetMap_Toolkit for pulling data as response from query

alelom commented 4 years ago

Let's have a chat on Skype.

rolyhudson commented 4 years ago

incredible response times!! 👍

rwemay commented 4 years ago

@alelom beat me to it, was going to say have a chat.

alelom commented 4 years ago

Hopefully our chat should have clarified things. @rwemay In a nutshell, we observed that the use case for @rolyhudson should be covered by the HTTP_Toolkit, no need for a new Adapter.

Just for reference, I'm including some useful links here: https://github.com/BHoM/documentation/wiki/The-Adapter-Interface https://github.com/BHoM/documentation/wiki/The-BHoM-Toolkit

Feel free to close this if it's all clear :) Thanks

rolyhudson commented 4 years ago

🤣 The solution to the question.... Is you don't need to implement an adapter here. 😆 HTTP_Adapter will handle this soon. And in the short term keep using HTTP.Compute.GetRequest. Just need a review and approval on this PR: https://github.com/BHoM/HTTP_Toolkit/pull/35 to make sure HTTP.Compute.GetRequest is marked as deprecated and changed back to public to temporarily allow the request.