Closed FraserGreenroyd closed 4 years ago
@FraserGreenroyd we need to add exceptions for the ModifyReturnsSameType: it does not cover when the method returns void because it modifies inputs by reference.
For the same reason, I think we should allow:
void
or boolean
(operation success)So after discussion with @FraserGreenroyd and @awakeman :
We don't allow modify by ref in engine methods to ensure no backward propagation happens ever (even if you could be deepcloning inside to protect)
In the case of CopyBHoMObjectProperties()
, we need to change the return type from void to T
, return target
, and deepcopying to protect the modification by ref.
In the case of WrapNonBHoMObjects()
, that should actually be a convert method.
For now, avoiding compliance and moving them in Adapter. Material for another sprint.
The following compliance issues have been found for this repository. Please see the checklist below.
Compliance issue for InputAttributeStartsLower
Compliance issue for NameMatchesFileName
Compliance issue for ModifyReturnsSameType