Compliance issues

[FraserGreenroyd]

The following compliance issues have been found for this repository. Please see the checklist below.

Compliance issue for InputAttributeStartsLower

• [x] Input attribute should start with a lowercase letter in BHoM_Adapter\Adapter_Engine\Modify\CopyBHoMObjectProperties.cs at line 40, column 82

Compliance issue for NameMatchesFileName

• [x] Method name must match file name in BHoM_Adapter\Adapter_Engine\Query\GetModules.cs at line 35, column 53

Compliance issue for ModifyReturnsSameType

• [ ] Modify methods must return the same type as their first parameter in BHoM_Adapter\Adapter_Engine\Modify\CopyBHoMObjectProperties.cs at line 40, column 22
• [ ] Modify methods must return the same type as their first parameter in BHoM_Adapter\Adapter_Engine\Modify\WrapNonBHoMObjects.cs at line 36, column 22

[alelom]

@FraserGreenroyd we need to add exceptions for the ModifyReturnsSameType: it does not cover when the method returns void because it modifies inputs by reference.

For the same reason, I think we should allow:

• Modify methods should be deemed compliant if they modify by input reference
• Modify 'by reference' methods should be deemed compliant if their return type is different from the input type, but only if the return type is void or boolean (operation success)

[alelom]

So after discussion with @FraserGreenroyd and @awakeman :

• We don't allow modify by ref in engine methods to ensure no backward propagation happens ever (even if you could be deepcloning inside to protect)

• In the case of CopyBHoMObjectProperties(), we need to change the return type from void to T, return target, and deepcopying to protect the modification by ref.

• In the case of WrapNonBHoMObjects(), that should actually be a convert method.

For now, avoiding compliance and moving them in Adapter. Material for another sprint.