search

BHoM / BHoM_Adapter

GNU Lesser General Public License v3.0
7 stars 6 forks source link

Add CreateNonExisting push type and methods #205

Closed IsakNaslundBh closed 4 years ago

IsakNaslundBh commented 4 years ago

Issues addressed by this PR

Closes #204

As stated in Issue, adding additional PushType, working exactly as FUllCRUD, except it does not call Update for the intersection of the venn diagram. Instead only UpdateTags is being called, for obejcts that do contain tags.

General principle: Create stuff not already in the model, leave the rest. Which is different from the default CRUD: Create stuff not existing, update the rest.

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/EkXvc8ZBXOZNr7HhmSEuzW8BS6e5UN6hCkJMXHCfO2E3Xg?e=lniam2

Changelog

Additional comments

@JosefTaylor , I think this should resolve https://github.com/BHoM/ETABS_Toolkit/issues/102

IsakNaslundBh commented 4 years ago

Have adressed comments by @alelom . For use in grasshopper, would not merge this before https://github.com/BHoM/Grasshopper_Toolkit/pull/486 has been merged though, as it would lead to erroneous behaviour for already placed enum components.

IsakNaslundBh commented 4 years ago

Tweaking descriptions in light off https://github.com/BHoM/BHoM_Engine/pull/1586

alelom commented 4 years ago

Seems to work fine, but I'd like to have an actual use case where this is useful tested. @JosefTaylor , do you have an example script where this new workflow could be tested, especially in light of the fact that this might be resolving your https://github.com/BHoM/ETABS_Toolkit/issues/102 ?

IsakNaslundBh commented 4 years ago

@alelom I added a testfile for testing against Etabs now:)

IsakNaslundBh commented 4 years ago

/azp run BHoM_Adapter.CheckInstaller

azure-pipelines[bot] commented 4 years ago
Azure Pipelines successfully started running 1 pipeline(s).