search

BHoM / BHoM_Adapter

GNU Lesser General Public License v3.0
7 stars 5 forks source link

Renamed PushType.FullCRUD to FullPush #214

Closed alelom closed 4 years ago

alelom commented 4 years ago

Issues addressed by this PR

Closes #206

NOTE: Dependant branches:

Adding do-not-merge because it will ripple through to:

alelom commented 4 years ago

@pawelbaran do you think we can push this through in your open PR? It would be great to get this done ASAP. I can help if needed.

pawelbaran commented 4 years ago

@alelom think it would be quite an effort to add dependent branch, pair it so that CI does not complain etc. (particularly as @FraserGreenroyd is on annual leave). But my ongoing PR is ready and I am happy to merge it as soon as you and @kThorsager approve - this could be resolved straight after (even today). Would that be fine?

alelom commented 4 years ago

@alelom think it would be quite an effort to add dependent branch, pair it so that CI does not complain etc. (particularly as @FraserGreenroyd is on annual leave). But my ongoing PR is ready and I am happy to merge it as soon as you and @kThorsager approve - this could be resolved straight after (even today). Would that be fine?

I think so, this was my proposal as well - as long as CI doesn't complain and let us do our job! 😄

IsakNaslundBh commented 4 years ago

Could we make sure we merge the other open PR before this, as that one has more changes in it (and this is a simple name change)

alelom commented 4 years ago

Could we make sure we merge the other open PR before this, as that one has more changes in it (and this is a simple name change)

Yes @IsakNaslundBh plan has changed and that's what we are currently doing. @pawelbaran to confim

pawelbaran commented 4 years ago

Fine for me - I will open a PR that aligns Revit_Toolkit to this one, but we can keep it hanging so no prob on my end.

FraserGreenroyd commented 4 years ago

I think so, this was my proposal as well - as long as CI doesn't complain and let us do our job! 😄

You do your job properly and my little CI friends won't disturb you :wink: 😄

alelom commented 4 years ago

I think so, this was my proposal as well - as long as CI doesn't complain and let us do our job! 😄

You do your job properly and my little CI friends won't disturb you 😉 😄

Yes, sure. (Just teasing you 😄 )

FraserGreenroyd commented 4 years ago

I think so, this was my proposal as well - as long as CI doesn't complain and let us do our job! 😄

You do your job properly and my little CI friends won't disturb you 😉 😄

Yes, sure. (Just teasing you 😄 )

Touché :smile:

alelom commented 4 years ago

Now conflicting branch, reopening with new one

alelom commented 4 years ago

New one: https://github.com/BHoM/BHoM_Adapter/pull/219