search

BHoM / BHoM_Adapter

GNU Lesser General Public License v3.0
7 stars 5 forks source link

BHoM_Adapter: Remove helper methods enabling pulling of results using FilterRequests #240

Closed IsakNaslundBh closed 3 years ago

IsakNaslundBh commented 4 years ago

Broken rules:

It is dangerous to pull results only specifying the type you want back. Results should only be pulled using the explicit ResultRequests.

Suggestions to restore compliance:

Remove support for pulling results with filter requests, which will be a great simplification to the Pull. Basically, removal of:

https://github.com/BHoM/BHoM_Adapter/blob/bded503a015afdbd726c414b5d92ce1ca9a2d590/BHoM_Adapter/AdapterActions/Pull.cs#L49-L57

and

https://github.com/BHoM/BHoM_Adapter/blob/bded503a015afdbd726c414b5d92ce1ca9a2d590/BHoM_Adapter/AdapterActions/_PullMethods/ReadResults.cs#L44-L51

and

https://github.com/BHoM/BHoM_Adapter/blob/bded503a015afdbd726c414b5d92ce1ca9a2d590/BHoM_Adapter/AdapterActions/_PullMethods/ReadResults.cs#L68-L107

This should be done after all current toolkits have been aligned!