BHoM_Adapter: add support for ILogicalRequest

[pawelbaran]

Description:

That works:

That does not:

It could be simply resolved with a Create.LogicalNotRequest method that would take Type and wrap it into a FilterRequest, however I would like to first check with if that is not too much of a crowbar solution, therefore raised in the BHoM_Adapter. What do you think @alelom?

[alelom]

I would be happy to add the support for this:

• if the LogicalNotRequest, and generally the ILogicalRequest, are defined in the base oM
• we then decide make the case that ILogicalRequest has to become a "standard" request common to any possible adapter, like the FilterRequest.

So far we have hardcoded support only for FilterRequest because it was deemed "universal". If we make an overhaul of the requests - where the logicalNot becomes one of the basic ones, together with then new FilterRequest (--> to become TypeRequest), then sure, we can add support. But I'd classify this as feature, it's not a bug - BHoM adapter could not know of LogicalNot.

[pawelbaran]

Right, good point about the Feature. When should we expect the overhaul of requests? Would be good to map out handling of ILogicalRequests as a part of it.

[alelom]

Not sure - wasn't you that created the concept of ILogicalRequest (which by the way I like a lot) in revit? You could simply make the case for moving the base interface in the oM, and defining the specific guidelines for that. Then it is a matter of adding the support in the adapter.

[pawelbaran]

It already is in Data_oM together with Create methods in Data_Engine.