search

BHoM / BHoM_Adapter

GNU Lesser General Public License v3.0
7 stars 6 forks source link

Add error message for failing pushing of Loads #246

Closed IsakNaslundBh closed 4 years ago

IsakNaslundBh commented 4 years ago

Issues addressed by this PR

Closes #245

Adds error message for pushing loads with no ids assigned to them.

Message with no name:

image

Message with name:

image

To be used by toolkits for better reporting on loads not being able to be pushed due to the objects lacking id information.

Test files

Changelog

Additional comments

alelom commented 4 years ago

LGTM, just added a couple of suggestions using parameterised strings $ as I don't like long string concatenations, harder to read

IsakNaslundBh commented 4 years ago

Not sure I agree on this being that much clearer, but not to fuzzed either way. Have applied your changes @alelom if you could re-review. Thanks

IsakNaslundBh commented 4 years ago

/azp run BHoM_Adapter.CheckInstaller

azure-pipelines[bot] commented 4 years ago
Azure Pipelines successfully started running 1 pipeline(s).