BHoM_Adapter: Automatic wrapping into a FilterRequest does not work on Remove

BHoM / BHoM_Adapter

GNU Lesser General Public License v3.0

7 stars 5 forks source link

BHoM_Adapter: Automatic wrapping into a FilterRequest does not work on Remove #247

Closed pawelbaran closed 3 years ago

pawelbaran commented 3 years ago

Description:

Pull component can accept a bare Type argument that is wrapped into a FilterRequest automatically. Similar behaviour would be welcome for Remove.

alelom commented 3 years ago

Sounds good. This is an item for next beta. We should refactor the FilterRequest, splitting their functionality in a TypeRequest and anything else needed. Then I'd like to simply add an implicit cast from Type to TypeRequest, to cover cases like these without having to propagate and duplicate functionality. I'll keep this in mind. Thanks @pawelbaran .

pawelbaran commented 3 years ago

This is an item for next beta.

Sure, that is why I marked it as a feature 👍 Absolutely no rush, it is a 100% nice to have.

alelom commented 3 years ago

Linked to https://github.com/BHoM/BHoM_Adapter/issues/239

alelom commented 3 years ago

Closed by https://github.com/BHoM/BHoM_Adapter/pull/264