search

BHoM / BHoM_Adapter

GNU Lesser General Public License v3.0
7 stars 6 forks source link

Introduce new AdapterIdFragment to replace CustomData usage #263

Closed alelom closed 3 years ago

alelom commented 3 years ago

NOTE: Depends on

https://github.com/BHoM/BHoM/pull/1033

Issues addressed by this PR

Closes https://github.com/BHoM/BHoM_Adapter/pull/263 Closes #255

Test files

See individual adapters.

Changelog

Additional comments

peterjamesnugent commented 3 years ago

@alelom question on this.

Should all the methods be AdapterIdName instead of AdapterId, we did make a change a while back to use AdapterNameId in place of AdapterId.

Or are we now reverting that change? May be worth clarifying before CustomData and hence the use of AdapterIdName is removed from the various adapters.

alelom commented 3 years ago

@alelom question on this.

Should all the methods be AdapterIdName instead of AdapterId, we did make a change a while back to use AdapterNameId in place of AdapterId.

Or are we now reverting that change? May be worth clarifying before CustomData and hence the use of AdapterIdName is removed from the various adapters.

Sorry, I should've reverted to Draft for this PR - still revising some details. I will reach you guys out for explanation today in the Structures call for more details.

IsakNaslundBh commented 3 years ago

/azp run BHoM_Adapter.CheckInstaller

azure-pipelines[bot] commented 3 years ago
Azure Pipelines successfully started running 1 pipeline(s).
IsakNaslundBh commented 3 years ago

/azp run BHoM_Adapter.CheckInstaller

azure-pipelines[bot] commented 3 years ago
Azure Pipelines successfully started running 1 pipeline(s).