search

BHoM / BHoM_Adapter

GNU Lesser General Public License v3.0
7 stars 5 forks source link

Adapter_Engine: AdapterId Query having grasshopper problems #283

Closed JosefTaylor closed 3 years ago

JosefTaylor commented 3 years ago

Description:

BH.Adapter.Engine.Query.AdapterId(this IBHoMObject bHoMObject, Type adapterIdFragmentType) doesn't pop up properly on the grasshopper canvas when coming from the ctrl+shift+b search

This might be a grasshopper_UI problem, but given that no other components seem to have the problem, I thought I'd start here.

Steps to reproduce:

open grasshopper, ctrl+shift+b search for "adapter query" - two identical options pop up. Click either one to place on the canvas, and the result is a blank query component with the warning message "this is a magic component ..." image image

interestingly, you can get to the method by placing a query and then selecting the AdapterId query.

Expected behaviour:

Test file(s):

https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/BHoM_Adapter/%23283-AdapterIdComponent.gh?csf=1&web=1&e=9FPfwb

FraserGreenroyd commented 3 years ago

@JosefTaylor can you confirm the last version of the BHoM you installed and if anyone else in your sphere is experiencing the same issue?

JosefTaylor commented 3 years ago

I'm running 210112_BuroHappold_BHoM_v4.1.alpha, and @maryannewachter is having the same issue.

peterjamesnugent commented 3 years ago

I am having the same issue on today's 210120 installer - I've also found once you've placed the component on the canvas and reopen the script it reverts back to a magic component.

Edit: Added a test script to OP.

adecler commented 3 years ago

It should have been fixed by this PR: https://github.com/BHoM/BHoM_Adapter/pull/290. I just tried it and the component is indeed created correctly for me.

Can you check that it works for you too ?

peterjamesnugent commented 3 years ago

@adecler works for me too, both using the test script and from the search menu.