search

BHoM / BHoM_Adapter

GNU Lesser General Public License v3.0
7 stars 5 forks source link

Fix AdapterId versioning #292

Closed adecler closed 3 years ago

adecler commented 3 years ago

Issues addressed by this PR

Closes #291

the versioning for AdaperId added in PR https://github.com/BHoM/BHoM_Adapter/pull/290 was invalid. This PR fixes that.

Test files

Try to input this into a FromJson component:

{ "_t" : "System.Reflection.MethodBase", "TypeName" : "{ \"_t\" : \"System.Type\", \"Name\" : \"BH.Engine.Adapter.Query, Adapter_Engine, Version=4.0.0.0, Culture=neutral, PublicKeyToken=null\" }", "MethodName" : "AdapterId", "Parameters" : ["{ \"_t\" : \"System.Type\", \"Name\" : \"BH.oM.Base.IBHoMObject\" }", "{ \"_t\" : \"System.Type\", \"Name\" : \"System.Type, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089\" }"] }

This corresponds to the AdapterId method as it was in the last beta.

adecler commented 3 years ago

FYI, you can easily generate a version key by using the following component:

image

Obviously, you need to run that before you make the changes 😄

adecler commented 3 years ago

/azp run BHoM_Adapter.CheckInstaller

azure-pipelines[bot] commented 3 years ago
Azure Pipelines successfully started running 1 pipeline(s).
FraserGreenroyd commented 3 years ago

@BHoMBot check versioning

bhombot-ci[bot] commented 3 years ago
@FraserGreenroyd to confirm, `check-versioning` task is now queued.