Closed IsakNaslundBh closed 2 years ago
@BHoMBot check compliance @BHoMBot check required
@BHoMBot check compliance @BHoMBot check required
The change makes sense to me. However, I'm considering whether we could revise the GetDependencyObjects()
signature.
The inner logic effectively makes the adapter
parameter optional, as the method proceeds whether it finds any module or not.
Therefore I would either:
GetDependencyObjects<T>(IEnumerable<T> objects, List<Type> dependencyTypes, IBHoMAdapter adapter = null)
I just think this would make things clearer; even though one method would probably rarely be used, we still should consider that this method is publicly available as part of an Engine. What do you think @IsakNaslundBh ?
I just think this would make things clearer; even though one method would probably rarely be used, we still should consider that this method is publicly available as part of an Engine. What do you think @IsakNaslundBh ?
Happy to change to that!
Also, as this can not go in until next milestone, would not mind to have a quick brainstorm call with you about this in general, and maybe iron out a few things here before merge anyway :)
would not mind to have a quick brainstorm call with you about this in general, and maybe iron out a few things here before merge anyway
sounds great!
@BHoMBot check core
@JosefTaylor @alelom I had to rebase and forcepush an update to this PR due to the framework update PR https://github.com/BHoM/BHoM_Adapter/pull/308 that was merged last week. To be able to retest this, please ensure to delete the branch locally and pull it again.
@BHoMBot check compliance @BHoMBot check required
@BHoMBot check ready-to-merge
Issues addressed by this PR
Closes #304
Adds AdapterModule for fetching dependency objects for edgecases where the method in Reflection_Engine can not handle it.
First usecase added for getting Loadcases from LoadCombinations
Test files
Changelog
Additional comments