BHoM / BHoM_Adapter

GNU Lesser General Public License v3.0
7 stars 5 forks source link

BHoM_Adapter: adding method to unpack objects provided in Push #343

Closed alelom closed 1 year ago

alelom commented 1 year ago

NOTE: Depends on

https://github.com/BHoM/BHoM_Engine/pull/3001

Issues addressed by this PR

Closes https://github.com/BHoM/BHoM_Adapter/issues/341 Closes #177

Test files

See provided test project. We still do not have a concrete class that implements IContainer -- a test one is present in the test project.

Changelog

Additional comments

bhombot-ci[bot] commented 1 year ago
@alelom just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine
bhombot-ci[bot] commented 1 year ago
@alelom just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine
FraserGreenroyd commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 3 requests in the queue ahead of you.
FraserGreenroyd commented 1 year ago

@BHoMBot check core @BHoMBot check null-handling @BHoMBot check serialisation

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `core` - check `null-handling` - check `serialisation`
FraserGreenroyd commented 1 year ago

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge, project-compliance

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.