BHoM / BHoM_Adapter

GNU Lesser General Public License v3.0
7 stars 7 forks source link

Structures_AdapterModules: create push pre-process module to match and replace objects in Loads by Guid, to allow push of them at the same type of objects #348

Closed alelom closed 1 year ago

alelom commented 1 year ago

Description:

By leveraging #347 , we can create a push pre-process module to match and replace objects in Loads by Guid. By doing so, the reference of the objects that the Loads target will be already present when the GetDependencies is invoked later in the push. This way, some workflows that otherwise would rely on adding more DependencyTypes to push multiple types at the same time (https://github.com/BHoM/BHoM_Adapter/issues/331) – referring in particular to those required by https://github.com/BHoM/Karamba3D_Toolkit/pull/4 – can rely on this module instead.

This, issue, together with #347, are to be considered additional features and not a replacement of https://github.com/BHoM/BHoM_Adapter/issues/331; #331 is a more general feature not limited only to Loads and Structural adapters, and leverages the internal workings of the Adapter and comparers. The work for aligning adapters (in particular structural adapters) to https://github.com/BHoM/BHoM_Adapter/issues/331 should still be pushed forward, whilst the implementation of this and #347 can help simplify and unblocking workflows for https://github.com/BHoM/Karamba3D_Toolkit/pull/4.

@al-fisher FYI