search

BHoM / BHoM_Adapter

GNU Lesser General Public License v3.0
7 stars 6 forks source link

Fix ETABS Levels Pushing #389

Closed GCRA101 closed 2 months ago

GCRA101 commented 3 months ago

NOTE: Depends on

https://github.com/BHoM/ETABS_Toolkit/compare/ETABS_Toolkit-%23435-FixLevelsPushing?expand=1

Issues addressed by this PR

Closes #435 from the ETABS Toolkit

When using ETABS, it's necessary to push levels before any other objects to avoid errors. Separating the levels from all the other objects and making sure that they are always pushed first into the new blank ETABS model, it's possible to resolve this issue.

Test files

Changelog

Separated Levels from other objects making sure they are pushed first.

Additional comments

GCRA101 commented 2 months ago

@IsakNaslundBh , thanks a lot for reviewing this PR.

Looking forward to discussing together how we can sort out the issue in line with your comments. ;)

Giorgio

peterjamesnugent commented 2 months ago

Going to close this for now and have raised an issue here to be tackled for the 8.0 milestone: https://github.com/BHoM/BHoM_Adapter/issues/390