BHoM / BHoM_Datasets

Repository for storing datasets for deployment as part of the BHoM e.g. reference libraries, standard objects etc.
GNU Lesser General Public License v3.0
2 stars 2 forks source link

Align dataset folder with namespace #122

Closed IsakNaslundBh closed 1 year ago

IsakNaslundBh commented 2 years ago

NOTE: Depends on

Does not depend on to compile, but should not be merged before https://github.com/BHoM/BHoM_Engine/pull/2845

Issues addressed by this PR

Closes #121

Update Dataset folder to match namespace for Structures and Graphics

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/ElZxIn8tk9hEmFlsGsYwfxsBDQj3Q6jEijbald347pTANg?e=2geUir

Note 1 to test this, the C:\ProgramData\BHoM\Datasets folder needs to be cleared of any current instances of the files being migrated, as without doing so, the files on main will still exist and be picked up.

Note 2, you will need to build versioning toolkit after you have compiled this to ensure that the Upgraders are copied across to the UpgradesFile.

Changelog

Additional comments

Putting this on a separate branch name intentionally, as the versioning should be able to be merged without this PR being merged at the same time. This is raised now, before the versioning is merged, to enable simpler testing.

@peterjamesnugent @JosefTaylor putting you as reviewers as a bit of FYI that this might be happening.

IsakNaslundBh commented 2 years ago

Putting do-not-merge tag on until versioning PRs have been merged

IsakNaslundBh commented 2 years ago

Would not merge this PR until after the release of BHoM 5.2 beta. Best merged early in 5.3. Before merging, the code should be evaluated to find any places where the library engine is called, referencing any of the datasets in here and appropriate updates made to ensure the same data is still received.

FraserGreenroyd commented 2 years ago

@JosefTaylor would you have any capacity to review this so we can merge before the beta? 😄

JosefTaylor commented 2 years ago

@BHoMBot check copyright-compliance @BHoMBot check dataset-compliance @BHoMBot check project-compliance

JosefTaylor commented 2 years ago

@BHoMBot check compliance

IsakNaslundBh commented 2 years ago

thanks @JosefTaylor .

As discussed offline, will aim to get this merged early next milestone, rather than in this one.

Will also require the Versioning json file to get its name updated to 6.0.

FraserGreenroyd commented 1 year ago

@IsakNaslundBh any update on this?

peterjamesnugent commented 1 year ago

@BHoMBot check required

bhombot-ci[bot] commented 1 year ago
@peterjamesnugent to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine
IsakNaslundBh commented 1 year ago

@BHoMBot check copyright-compliance @BHoMBot check dataset-compliance @BHoMBot check project-compliance

bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `copyright-compliance` - check `dataset-compliance` - check `project-compliance` There are 9 requests in the queue ahead of you.
IsakNaslundBh commented 1 year ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `ready-to-merge` There are 44 requests in the queue ahead of you.
IsakNaslundBh commented 1 year ago

@BHoMBot check core

bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `core` There are 23 requests in the queue ahead of you.
IsakNaslundBh commented 1 year ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `ready-to-merge` There are 11 requests in the queue ahead of you.