Closed IsakNaslundBh closed 1 year ago
Putting do-not-merge tag on until versioning PRs have been merged
Would not merge this PR until after the release of BHoM 5.2 beta. Best merged early in 5.3. Before merging, the code should be evaluated to find any places where the library engine is called, referencing any of the datasets in here and appropriate updates made to ensure the same data is still received.
@JosefTaylor would you have any capacity to review this so we can merge before the beta? 😄
@BHoMBot check copyright-compliance @BHoMBot check dataset-compliance @BHoMBot check project-compliance
@BHoMBot check compliance
thanks @JosefTaylor .
As discussed offline, will aim to get this merged early next milestone, rather than in this one.
Will also require the Versioning json file to get its name updated to 6.0.
@IsakNaslundBh any update on this?
@BHoMBot check required
@BHoMBot check copyright-compliance @BHoMBot check dataset-compliance @BHoMBot check project-compliance
@BHoMBot check ready-to-merge
@BHoMBot check core
@BHoMBot check ready-to-merge
NOTE: Depends on
Does not depend on to compile, but should not be merged before https://github.com/BHoM/BHoM_Engine/pull/2845
Issues addressed by this PR
Closes #121
Update Dataset folder to match namespace for Structures and Graphics
Test files
https://burohappold.sharepoint.com/:f:/s/BHoM/ElZxIn8tk9hEmFlsGsYwfxsBDQj3Q6jEijbald347pTANg?e=2geUir
Note 1 to test this, the C:\ProgramData\BHoM\Datasets folder needs to be cleared of any current instances of the files being migrated, as without doing so, the files on main will still exist and be picked up.
Note 2, you will need to build versioning toolkit after you have compiled this to ensure that the Upgraders are copied across to the UpgradesFile.
Changelog
Additional comments
Putting this on a separate branch name intentionally, as the versioning should be able to be merged without this PR being merged at the same time. This is raised now, before the versioning is merged, to enable simpler testing.
@peterjamesnugent @JosefTaylor putting you as reviewers as a bit of FYI that this might be happening.