search

BHoM / BHoM_Datasets

Repository for storing datasets for deployment as part of the BHoM e.g. reference libraries, standard objects etc.
GNU Lesser General Public License v3.0
2 stars 3 forks source link

Add embodied carbon to materials #13

Closed JosefTaylor closed 4 years ago

JosefTaylor commented 5 years ago

NOTE: Depends on

Adapting to BHoM PR 560

Issues addressed by this PR

Closes #12

Re-serialized US sections and materials with embodied carbon

Test files

Changelog

Additional comments

IsakNaslundBh commented 5 years ago

@enarhi Added you as a reviewer for this, as I think you are better placed to check that the US sections still work:)

JosefTaylor commented 4 years ago

@enarhi Can you check this?

JosefTaylor commented 4 years ago

@FraserGreenroyd is this PR title good enough for ya?

JosefTaylor commented 4 years ago

/azp run BHoM_Datasets.CheckInstaller

JosefTaylor commented 4 years ago

@IsakNaslundBh feel free to merge when you get to it

JosefTaylor commented 4 years ago

@enarhi @IsakNaslundBh I fixed the issue with the missing HSS, number of sections is now correct.

JosefTaylor commented 4 years ago

Scratch that, I serialized without the carbon. Will fix this afternoon.

JosefTaylor commented 4 years ago

All's well. @IsakNaslundBh @FraserGreenroyd @enarhi review and merge when ready!

FraserGreenroyd commented 4 years ago

@enarhi the deadline for including this PR in the 3.0 beta installer is 2pm UTC Thursday 19th December 2019, will you be able to review before then or can you/ @JosefTaylor ask someone else to take a look? As this is US based data we're keen to ensure a US based engineer takes a review before we merge :smile:

enarhi commented 4 years ago

Could have sworn I had already approved, as I had already reviewed a few days ago with the new changes! LGTM!

al-fisher commented 4 years ago

Ah! Thanks @enarhi! 👍