BHoM / BHoM_Datasets

Repository for storing datasets for deployment as part of the BHoM e.g. reference libraries, standard objects etc.
GNU Lesser General Public License v3.0
2 stars 2 forks source link

Added glulam and sawn Timber datasets #141

Closed kaichelliah closed 1 year ago

kaichelliah commented 1 year ago

Generated and added glulam and sawn timber datasets

NOTE: Depends on

https://github.com/BHoM/BHoM/pull/1469

Issues addressed by this PR

https://github.com/BHoM/BHoM_Datasets/issues/95 close #95 close #114

Material Property datasets for sawn timber and glulam have been provided based of Eurocode sourced datasets.

Test files

Changelog

Additional comments

New issue to be opened will be to adapt or re-create the current timberRectangularSection Methods to accomodate the sawntimber/glulam material fragments.

FraserGreenroyd commented 1 year ago

@BHoMBot check dataset-compliance

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `dataset-compliance` There are 2 requests in the queue ahead of you.
kaichelliah commented 1 year ago

@IsakNaslundBh Thanks for that I've updated the source and committed. Have you seen my issue: https://github.com/BHoM/BHoM/issues/1518 I hard to really test these datasets in use properly in a workflow other than doing value checks until we sort this out. Happy to push LVL next week and maybe have a look at fixing this issue if your ok with that?

IsakNaslundBh commented 1 year ago

@BHoMBot check copyright-compliance @BHoMBot check dataset-compliance @BHoMBot check project-compliance

bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `copyright-compliance` - check `dataset-compliance` - check `project-compliance` There are 40 requests in the queue ahead of you.
FraserGreenroyd commented 1 year ago

@BHoMBot check dataset-compliance

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `dataset-compliance` There are 2 requests in the queue ahead of you.
FraserGreenroyd commented 1 year ago

@BHoMBot check dataset-compliance

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `dataset-compliance` There are 1 requests in the queue ahead of you.
FraserGreenroyd commented 1 year ago

@BHoMBot check dataset-compliance

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `dataset-compliance` There are 1 requests in the queue ahead of you.
FraserGreenroyd commented 1 year ago

@BHoMBot check dataset-compliance

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `dataset-compliance` There are 1 requests in the queue ahead of you.
FraserGreenroyd commented 1 year ago

@BHoMBot check dataset-compliance

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `dataset-compliance`
FraserGreenroyd commented 1 year ago

@BHoMBot check dataset-compliance

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `dataset-compliance`
IsakNaslundBh commented 1 year ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `ready-to-merge`
bhombot-ci[bot] commented 1 year ago
FAO: @FraserGreenroyd @FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is ready-to-merge. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `13482309946`
FraserGreenroyd commented 1 year ago

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 13482309946

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd I have now provided a passing check on reference `13482309946` as requested.