search

BHoM / BHoM_Datasets

Repository for storing datasets for deployment as part of the BHoM e.g. reference libraries, standard objects etc.
GNU Lesser General Public License v3.0
2 stars 2 forks source link

Update US_SteelSection values with high diff #159

Open Martian42 opened 2 months ago

Martian42 commented 2 months ago

NOTE: Depends on

Issues addressed by this PR

Closes #157

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/BHoM_Datasets/%23157-Correct%20US%20steel%20section%20properties%20with%20larger%20than%202%20percent%20difference?csf=1&web=1&e=pyIwrm

Changelog

Additional comments

The inaccuracy is from the catalogue side. All values which is higher than 2% diff between BHoM and catalogue value has been updated to BHoM value.

peterjamesnugent commented 1 month ago

@BHoMBot check dataset-compliance

bhombot-ci[bot] commented 1 month ago
@peterjamesnugent to confirm, the following actions are now queued: - check `dataset-compliance` There are 24 requests in the queue ahead of you.
peterjamesnugent commented 1 month ago

@BHoMBot check required

bhombot-ci[bot] commented 1 month ago
@peterjamesnugent to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
Martian42 commented 1 month ago

@Martian42, I believe you have serialised the Dataset with rounded values, can you reserialise the dataset without any rounding please so it is identical between the BHoMDataset and our Integration methods (otherwise we are just adding a %Diff for no reason).

image

Thanks @peterjamesnugent, correctly formatted the BHoM values, test script no longer showing anything over 2% diff! image

peterjamesnugent commented 1 month ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 month ago
@peterjamesnugent to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
peterjamesnugent commented 1 month ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 month ago
@peterjamesnugent to confirm, the following actions are now queued: - check `ready-to-merge` There are 6 requests in the queue ahead of you.
peterjamesnugent commented 1 month ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 month ago
@peterjamesnugent to confirm, the following actions are now queued: - check `ready-to-merge`
peterjamesnugent commented 1 month ago

@BHoMBot check required

bhombot-ci[bot] commented 1 month ago
@peterjamesnugent to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` There are 4 requests in the queue ahead of you.
peterjamesnugent commented 1 month ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 month ago
@peterjamesnugent to confirm, the following actions are now queued: - check `ready-to-merge` There are 9 requests in the queue ahead of you.