Closed MartinHenriksen closed 3 years ago
These are at the top level Datasets/SectionProperties
. @IsakNaslundBh , we talked previously about organising these to better match/reflect namespaces, so more like Datasets/Structure/SectionProperties
. Don't know if we want to merge more into the top level before shifting all of these?
New EU profiles are not shown in the dropdown in CreateData node. They appear to be nested one level higher than UK sections, because they are achievable using Explode.
@MartinHenriksen , for this, make sure you have only a single Dataset in each of the JSON files. The FIle adapter might be adding rather than replacing if you have been pushing multiple times to the same file!
These are at the top level Datasets/SectionProperties. @IsakNaslundBh , we talked previously about organising these to better match/reflect namespaces, so more like Datasets/Structure/SectionProperties. Don't know if we want to merge more into the top level before shifting all of these?
@rwemay this has been asked for for quite some time, and given we will need to put a versioning system in place etc anyways to handle the UK and US sections, it will not be that big of a difference to take care of EU sections as well. Given that this will significantly help the EU guys, I prefer to get this in without being blocked off at this stage.
@IsakNaslundBh that is exactly what was happening - maintenance script updated to delete before writing to prevent this.
Sections hierarchy correct now. All necessary values are there. Would be good to correct inconsistent naming: EU has 'CHS60.3x4', while the same section in UK is named 'CHS 60.3x4.0', so with whitespace and trailing zero.
dataset updated to your comments @arturtomczak
@staintono while the calculation method you reference might be more accurate, the more conservative calculation method is what we are using in UK and US sections. This is also what is used in Both Robot and RFEM so I think the conservative value is more in line with what the user will expect. RFEM: Robot:
Added common EU section profiles sourced from manufacturers sites (Arcelormittal Orange Book and Tata Steel Blue Book). Datasets added: CHS, RHS, SHS, IPE, HE, UPE, UPN, L-equal and L-unequal
Issues addressed by this PR
Closes #6
Test files
to test copy the "EU_SteelSections" folder into
C:\ProgramData\BHoM\Datasets\SectionProperties
Changelog
'Added EU section properties to Datasets'
Additional comments
Warping constants for channel sections in the Orange Book have been miscalculated (overly conservative) - the authors have been notified