BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

Global : Removal of unnecessary Create methods simply exposing only the Public Defining properties #1155

Open al-fisher opened 5 years ago

al-fisher commented 5 years ago

Following successful close out of https://github.com/BHoM/BHoM_UI/issues/124 we can simplify greatly the number of Create methods needed.

Create methods will only be required specifically where the object is created based on a Derived or any non-Defining property (or combination of)

al-fisher commented 5 years ago

Have added this to 2.5 milestone. As part of planning suggest we perhaps break into focused issues - targeting specific namespaces.

adecler commented 5 years ago

I agree with the intention but not with the timing. I would stick with only closing https://github.com/BHoM/BHoM_UI/issues/124 for this release as this absolutely need a perfect retro-compatibility to avoid breaking every single script there is. This is not a very difficult exercise but one that will require time that we don't have before the deadline for implementation and testing.

There is also a few things that need to be done properly and are not necessarily as obvious as they might seem:

al-fisher commented 5 years ago

@adecler this was assigned to 2.5 milestone. Agreed with comments above

adecler commented 5 years ago

My bad, I am blind 😋

FraserGreenroyd commented 4 years ago

I've reassigned this issue to 3.1 because it is a fairly significant task that I don't think will be feasible before 3.0 closure.

I would agree with the discussion on raising specific issues in specific namespaces where appropriate, with relevant discipline leads working out which methods are most appropriate for them.

@adecler can I check, does the auto-created components reflect description attributes of the object properties onto the input hover mechanism for components? I'm wondering if, for those who only have default creates that need removing, it would be good to tie in the moving of their input attribute descriptions to the objects so that documentation for the user is not lost as part of the process?

al-fisher commented 3 years ago

To be tackled after close out of: https://github.com/BHoM/Versioning_Toolkit/issues/96