BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 14 forks source link

Geometry_Engine: DistributeOutlines to remain #1713

Open kThorsager opened 4 years ago

kThorsager commented 4 years ago

Broken rules:

DistributeOutlines was deprecated as it was planned to be moved to the Spatial_Engine, but as it is a geometrical operation and is currently used in the Geometry_Engine it should remain. (Create PlanarSurface needs it and can't reference Spatial_Engine)

So the deprecated attribute should at least be removed

If the code is identical (or close enough) the method in Spatial_Engine should be made to use this one. Otherwise some other kind of unification should be found, dislike the thought of identical methods in different projects which does different things

pawelbaran commented 3 years ago

It has been on my list of issues to raise for a long time - the two methods look like a real mess. Agreed with @kThorsager that it is impossible to delete the Geometry_Engine method as it is used inside the project. So the most intuitive solution that comes to my mind is to:

Naturally, I expect it to be more tricky than it sounds 🐒

I am assigning this to @LMarkowski as it seems to fall into his basket - I hope it is fine.