Open kThorsager opened 4 years ago
It has been on my list of issues to raise for a long time - the two methods look like a real mess. Agreed with @kThorsager that it is impossible to delete the Geometry_Engine method as it is used inside the project. So the most intuitive solution that comes to my mind is to:
DeprecatedAttribute
from Geometry_Engine methods (clean up the code - it looks like there is quite some boilerplate)BH.Engine.Geometry.Compute.DistributeOutlines
in Spatial_EngineNaturally, I expect it to be more tricky than it sounds 🐒
I am assigning this to @LMarkowski as it seems to fall into his basket - I hope it is fine.
Broken rules:
DistributeOutlines was deprecated as it was planned to be moved to the Spatial_Engine, but as it is a geometrical operation and is currently used in the Geometry_Engine it should remain. (Create
PlanarSurface
needs it and can't reference Spatial_Engine)So the deprecated attribute should at least be removed
If the code is identical (or close enough) the method in Spatial_Engine should be made to use this one. Otherwise some other kind of unification should be found, dislike the thought of identical methods in different projects which does different things