search

BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

Geometry_Engine: Resolve warning for PrincipalCurvatureAtParamater #2069

Open adecler opened 3 years ago

adecler commented 3 years ago

Description:

See discussion here for details: https://github.com/BHoM/BHoM_Engine/pull/2028#discussion_r506557289

theThorsager commented 3 years ago

Comment on the comment here. The warning could probably be suppressed by creating the coordinate system using the constructor in the oM rather than the Create method

@IsakNaslundBh Haha, was hoping for something more refined than "implement it yourself without the warning"

But suppose it's fairly easy in this case new Cartesian(new Point(), dU.Normalise(), normal.CrossProduct(dU.Normalise()), normal)

But given the implications around toe threading and merge conflicts, I'll leave it open to find a good time to raise and merge something to that effect

IsakNaslundBh commented 3 years ago

@IsakNaslundBh Haha, was hoping for something more refined than "implement it yourself without the warning"

But suppose it's fairly easy in this case new Cartesian(new Point(), dU.Normalise(), normal.CrossProduct(dU.Normalise()), normal)

Haha, well, the create methods involve hand holding and warnings, the constructors does not ;). And, yeah, given it felt as something quite easy to do, I thought that could be a solution for this situation. If it would require some 100 lines of code to be run, I probably would advice to live with it until we get some warning suppression mechanism in place!

Really great work with the Nurbs stuff btw! 🚀 Have only fallen halfway down the Nurbs hole before, but have always been pulled back up again before getting around to do anything with it, so exciting to finally get it in!