BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 14 forks source link

Geometry_Engine - handle nulls #2487

Open FraserGreenroyd opened 3 years ago

FraserGreenroyd commented 3 years ago

Note, where the method begins with BH.oM - this means it is a Create method.

The following methods need appropriate null handling of their inputs. You can use @BHoMBot check null-handling on a draft PR to check progress if needed - you're ultimately looking for a reduction in errors from the master/main branch. I can run more localised tests to confirm against if needed to confirm specific methods.

peterjamesnugent commented 3 years ago

A NullCheck method has been added to the Geometry_Engine - it is worth considering adding a deepCheck variable. See explanation here: https://github.com/BHoM/BHoM_Engine/pull/2504#discussion_r644040971

rolyhudson commented 3 years ago

@FraserGreenroyd - is the above list exhaustive in that it contains only the methods requiring null handling and those left out do not require null handling?

FraserGreenroyd commented 3 years ago

Correct as at time of publishing yes @rolyhudson - anything not included did not appear in the reports at the time run.