BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 14 forks source link

Modify all website urls within BHoM related repositories to reference a central location #3027

Closed travispotterBH closed 1 year ago

travispotterBH commented 1 year ago

Description:

Links to websites as exposed through buttons in each UI should be located in a central location so that a links can be updated across all UIs in one modification.

travispotterBH commented 1 year ago

@FraserGreenroyd Considering assigning this to my intern around early June as a good way for them to get acquainted with moving around the codebase. sound good?

FraserGreenroyd commented 1 year ago

If we haven't got round to it ourselves by then, sure.

travispotterBH commented 1 year ago

See this: https://github.com/BHoM/Excel_UI/pull/381

travispotterBH commented 1 year ago

@FraserGreenroyd Not sure the work down actually completes this. We may want to reopen. I believe this is a task in two parts. Create method which can be used to generate the URLs(as done in #3073), and then find ever place where we need to implement this. @desaiwangBH This can be the next task.

desaiwangBH commented 1 year ago

Existing link types: (WIP)

Documentation: some needs to be updated to bhom.xyz

Codebase: https://github.com/BHoM/...

External:

Image:

Style sheets:

FraserGreenroyd commented 1 year ago

@FraserGreenroyd Not sure the work down actually completes this. We may want to reopen. I believe this is a task in two parts. Create method which can be used to generate the URLs(as done in #3073), and then find ever place where we need to implement this. @desaiwangBH This can be the next task.

I would consider that a separate issue to be raised and resolved, as the scope of this task with its remarks prior to the PR have been completed, so I wouldn't now grow the scope of the issue, I'd raise a new one in the relevant repositories where updates need to be made.

travispotterBH commented 1 year ago

@desaiwangBH please proceed as mentioned by Fraser. Raise an issue. Thanks!