BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

Analytical_Engine: Fix Querying geometry of Panel #3237

Closed Tom-Kingstone closed 8 months ago

Tom-Kingstone commented 8 months ago

NOTE: Depends on

Issues addressed by this PR

Closes #2363

Querying the geometry of an IPanel<IEdge, IOpening> now can no longer produce a non-planar PlanarSurface if the Panel in question is non-planar.

Test files

#2356 -IsPlanar-PlanarSurface.zip

Changelog

Additional comments

Tom-Kingstone commented 8 months ago

@BHoMBot check core @BHoMBot check compliance

bhombot-ci[bot] commented 8 months ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `core` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 34 requests in the queue ahead of you.
FraserGreenroyd commented 8 months ago

@BHoMBot check serialisation @BHoMBot check null-handling

bhombot-ci[bot] commented 8 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `serialisation` - check `null-handling` There are 30 requests in the queue ahead of you.
FraserGreenroyd commented 8 months ago

@BHoMBot check versioning

bhombot-ci[bot] commented 8 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `versioning` There are 40 requests in the queue ahead of you.
FraserGreenroyd commented 8 months ago

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests, installer

bhombot-ci[bot] commented 8 months ago
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.
FraserGreenroyd commented 8 months ago

@BHoMBot this is a DevOps instruction. I am granting dispensation to be granted on check ref. 20395350862

bhombot-ci[bot] commented 8 months ago
@FraserGreenroyd I'm sorry, but I am not authorised to take that instruction from you.
FraserGreenroyd commented 8 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 8 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `ready-to-merge` There are 31 requests in the queue ahead of you.
bhombot-ci[bot] commented 8 months ago
FAO: @FraserGreenroyd @FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is ready-to-merge. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `20395650118`
FraserGreenroyd commented 8 months ago

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 20395650118

bhombot-ci[bot] commented 8 months ago
@FraserGreenroyd I have now provided a passing check on reference `20395650118` as requested.