BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 14 forks source link

BHoM_Engine: NewInternalElementXD moved to Query class #3245

Closed Tom-Kingstone closed 9 months ago

Tom-Kingstone commented 9 months ago

NOTE: Depends on

Issues addressed by this PR

Closes #1572

Moved all occurrences of NewInternalElement2D from Create to Query as in issue, and deleted methods with ToBeRemoved attributes.

Test files

Changelog

Additional comments

Tom-Kingstone commented 9 months ago

@BHoMBot check core @BHoMBot check compliance

bhombot-ci[bot] commented 9 months ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `core` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
Tom-Kingstone commented 9 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 9 months ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 1 requests in the queue ahead of you.
Tom-Kingstone commented 9 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 9 months ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
Tom-Kingstone commented 9 months ago

@BHoMBot check core

bhombot-ci[bot] commented 9 months ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `core`
Tom-Kingstone commented 9 months ago

@BHoMBot check versioning

bhombot-ci[bot] commented 9 months ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `versioning`
Tom-Kingstone commented 9 months ago

@BHoMBot check versioning

bhombot-ci[bot] commented 9 months ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `versioning`
FraserGreenroyd commented 9 months ago

@BHoMBot check versioning

bhombot-ci[bot] commented 9 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `versioning`
Tom-Kingstone commented 9 months ago

@BHoMBot check versioning

bhombot-ci[bot] commented 9 months ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `versioning`
Tom-Kingstone commented 9 months ago

@BHoMBot check installer

bhombot-ci[bot] commented 9 months ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `installer`
Tom-Kingstone commented 9 months ago

@BHoMBot check versioning

bhombot-ci[bot] commented 9 months ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `versioning`
Tom-Kingstone commented 9 months ago

@BHoMBot check core @BHoMBot check compliance

bhombot-ci[bot] commented 9 months ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `core` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
Tom-Kingstone commented 9 months ago

@BHoMBot check core

bhombot-ci[bot] commented 9 months ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `core`
FraserGreenroyd commented 9 months ago

@BHoMBot check core

bhombot-ci[bot] commented 9 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `core`
FraserGreenroyd commented 9 months ago

@BHoMBot check core

bhombot-ci[bot] commented 9 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `core`
FraserGreenroyd commented 9 months ago

@BHoMBot check null-handling @BHoMBot check serialisation

bhombot-ci[bot] commented 9 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `null-handling` - check `serialisation`
FraserGreenroyd commented 9 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 9 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `ready-to-merge`
FraserGreenroyd commented 9 months ago

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

bhombot-ci[bot] commented 9 months ago
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.