search

BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

Geometry_Engine: Shouldn't FaceIndices method be named NodeIndices? #3254

Open pawelbaran opened 7 months ago

pawelbaran commented 7 months ago

Description:

As in the title, FaceIndices method returns indices of vertices that belong to a given mesh face: https://github.com/BHoM/BHoM_Engine/blob/a5674ef8b931aa5f3efb4c788240987b6ad2b6ab/Geometry_Engine/Query/FaceIndices.cs#L41-L51

Wouldn't NodeIndices be a more appropriate name?

pawelbaran commented 7 months ago

Looping @albinber in following the suggestion of @FraserGreenroyd 👍

alelom commented 7 months ago

Agree that it seems a more appropriate name. Not sure if there's any old usage convention on this naming though.