BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

Structure_Engine: Fix bug for the Mass method (for Panels) #3256

Closed peterjamesnugent closed 7 months ago

peterjamesnugent commented 7 months ago

Issues addressed by this PR

Closes #2854

Test files

https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/BHoM_Engine/Structure_Engine/%232854-MassPerAreaNotAccountingForReinforcementDensity/%232854.gh?csf=1&web=1&e=umvd2d

Changelog

Additional comments

The two Mass methods are quite old, is there an argument they are redundant now we have the Mass methods for IElementM and IElement1D?

FraserGreenroyd commented 7 months ago

@BHoMBot check compliance @BHoMBot check required

bhombot-ci[bot] commented 7 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
bhombot-ci[bot] commented 7 months ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 7 months ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
FraserGreenroyd commented 7 months ago

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

FraserGreenroyd commented 7 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 7 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `ready-to-merge`
bhombot-ci[bot] commented 7 months ago
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.
peterjamesnugent commented 7 months ago

@BHoMBot check required

bhombot-ci[bot] commented 7 months ago
@peterjamesnugent to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
peterjamesnugent commented 7 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 7 months ago
@peterjamesnugent to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 8 requests in the queue ahead of you.
bhombot-ci[bot] commented 7 months ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 7 months ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
FraserGreenroyd commented 7 months ago

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: dataset-compliance, unit-tests

bhombot-ci[bot] commented 7 months ago
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.
FraserGreenroyd commented 7 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 7 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `ready-to-merge`