BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

Environment_Engine: Compute Openings from a list of panels and a glazing ratio #3258

Closed Felix-Mallinder closed 7 months ago

Felix-Mallinder commented 7 months ago

NOTE: Depends on

Issues addressed by this PR

Closes #3226

Added compute method, as described in the linked issue, the method calculates window sizes based on glazing ratio, for externally facing panels and creates openings.

Test files

OpeningsByGlazingByRatioTestScript.zip Unzip, open in Rhino and check actual area is equal to expected area

Changelog

Additional comments

FraserGreenroyd commented 7 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 7 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 1 requests in the queue ahead of you.
Felix-Mallinder commented 7 months ago

@BHoMBot check for copyright-compliance

bhombot-ci[bot] commented 7 months ago
@FelixMallinder-BH sorry, I didn't understand. Was that comment an instruction for me? If so, could you state again what check you would like me to do? For a list of available instructions, please see [this wiki page](https://github.com/BHoM/documentation/wiki/Continuous-Integration).
Felix-Mallinder commented 7 months ago

@BHoMBot check copyright-compliance

bhombot-ci[bot] commented 7 months ago
@FelixMallinder-BH to confirm, the following actions are now queued: - check `copyright-compliance`
bhombot-ci[bot] commented 7 months ago
@FelixMallinder-BH fix requested for copyright headers. The errors with the copyright headers on the CS (`.cs`) files have been recorded as annotations on the checks tab. I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. Each CS (`.cs`) file that does not have the current copyright header will have it applied. The current copyright header can be examined [here](https://github.com/BHoM/BHoM/blob/main/COPYRIGHT_HEADER.txt). If you are happy for me to go ahead and perform this action, please reply with: > @BHoMBot fix copyright headers ref. `20780543059`
Felix-Mallinder commented 7 months ago

@BHoMBot fix copyright headers ref. 20780543059

bhombot-ci[bot] commented 7 months ago
@FelixMallinder-BH I'm sorry, but I cannot understand which check reference you are trying to provide. Please can you try again?
Tom-Kingstone commented 7 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 7 months ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
bhombot-ci[bot] commented 7 months ago
The check `copyright-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
Tom-Kingstone commented 7 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 7 months ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
bhombot-ci[bot] commented 7 months ago
@Tom-Kingstone fix requested for copyright headers. The errors with the copyright headers on the CS (`.cs`) files have been recorded as annotations on the checks tab. I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. Each CS (`.cs`) file that does not have the current copyright header will have it applied. The current copyright header can be examined [here](https://github.com/BHoM/BHoM/blob/main/COPYRIGHT_HEADER.txt). If you are happy for me to go ahead and perform this action, please reply with: > @BHoMBot fix copyright headers ref. `20780849163`
Tom-Kingstone commented 7 months ago

@BHoMBot fix copyright headers ref. 20780849163

bhombot-ci[bot] commented 7 months ago
@Tom-Kingstone sorry, but the check you're asking me to make automatic fixes for has not failed, so I cannot make any changes at this point.
Tom-Kingstone commented 7 months ago

@BHoMBot check copyright-compliance

bhombot-ci[bot] commented 7 months ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `copyright-compliance`
Tom-Kingstone commented 7 months ago

@BHoMBot check core @BHoMBot check compliance

bhombot-ci[bot] commented 7 months ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `core` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
bhombot-ci[bot] commented 7 months ago
The check `copyright-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
Tom-Kingstone commented 7 months ago

@BHoMBot check core @BHoMBot check compliance

bhombot-ci[bot] commented 7 months ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `core` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
Felix-Mallinder commented 7 months ago

Reviewed and re-tested @Tom-Kingstone 's changes, happy that they solved the previous issues and functionality follows.

FraserGreenroyd commented 7 months ago

@BHoMBot check required

bhombot-ci[bot] commented 7 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
bhombot-ci[bot] commented 7 months ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 7 months ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
FraserGreenroyd commented 7 months ago

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

FraserGreenroyd commented 7 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 7 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `ready-to-merge` There are 19 requests in the queue ahead of you.
bhombot-ci[bot] commented 7 months ago
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.