BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

Security_Engine: Camera Field of View bug fix #3266

Closed michal-pekacki closed 7 months ago

michal-pekacki commented 7 months ago

NOTE: Depends on

Issues addressed by this PR

Closes #3265

Test files

Changelog

Additional comments

michal-pekacki commented 7 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 7 months ago
@michal-pekacki to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
michal-pekacki commented 7 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 7 months ago
@michal-pekacki to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
michal-pekacki commented 7 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 7 months ago
@michal-pekacki to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
michal-pekacki commented 7 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 7 months ago
@michal-pekacki to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
michal-pekacki commented 7 months ago

@BHoMBot check required

bhombot-ci[bot] commented 7 months ago
@michal-pekacki to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
bhombot-ci[bot] commented 7 months ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 7 months ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 7 months ago
@michal-pekacki just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michal-pekacki on Revit_Toolkit
michal-pekacki commented 7 months ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 7 months ago
@michal-pekacki to confirm, the following actions are now queued: - check `unit-tests`
bhombot-ci[bot] commented 7 months ago
FAO: @FraserGreenroyd @FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `21146284981`
FraserGreenroyd commented 7 months ago

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 21146284981

bhombot-ci[bot] commented 7 months ago
@FraserGreenroyd I have now provided a passing check on reference `21146284981` as requested.
FraserGreenroyd commented 7 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 7 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `ready-to-merge`
FraserGreenroyd commented 7 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 7 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `ready-to-merge`