Closed pawelbaran closed 6 months ago
@BHoMBot check required
@BHoMBot check compliance
@BHoMBot check compliance
@FraserGreenroyd I requested dispensation against document compliance because it seems to be a bug on the side of the bot.
@BHoMBot check required
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 21690575707
@BHoMBot check ready-to-merge
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 21691286837
Issues addressed by this PR
Closes #3278
Test files
General tests are available here Edge cases covered here
Changelog
Additional comments
Issue originally raised by @peterjamesnugent, but he is still on leave, so adding @FraserGreenroyd and @albinber - please let it hang and leave it to the originator if not enough head space, no rush on this one 👍
EDIT: running into more and more issues with line fitting, I started gathering edge cases. I spent lots of effort trying to get them all covered using the existing analytical solution, but failed, which led me to rewrite
FitLine
method entirely by switching to numerical solution and adding an implementation of Singular Value Decomposition, inspired by this and that. Now the method is much more robust, which can be seen in the test files.A follow-up feature would be https://github.com/BHoM/BHoM_Engine/issues/3287.
tolerance
input to be removed fromFitLine
in a separate PR, see https://github.com/BHoM/BHoM_Engine/issues/3288.