search

BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

Geometry_Engine: Rewrite FitPlane method to leverage Singular Value Decomposition #3287

Closed pawelbaran closed 6 months ago

pawelbaran commented 6 months ago

Description:

Once https://github.com/BHoM/BHoM_Engine/pull/3280 gets merged, we will have an implementation of Singular Value Decomposition that can be applied in various applications. Once of them is line fitting (covered in the original PR), another one plane fitting. It would be desirable to rewrite the latter to leverage SVD as it seems to be very robust, I strongly believe more robust than my rather old attempt to compute eigenvectors using a mixture of geometrical tolerance and row echelon form.

@peterjamesnugent FYI

pawelbaran commented 6 months ago

I uploaded test script here, which contains a few edge cases where the current implementation fails.