search

BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

Geometry_Engine: Apply tolerance to preliminary check in FitLine #3288

Closed pawelbaran closed 6 months ago

pawelbaran commented 6 months ago

Description

https://github.com/BHoM/BHoM_Engine/pull/3280 changes the FitLine method in a way that makes tolerance input redundant. It would be good to remove it, rather in a separate PR to avoid the valuable feature being blocked due to versioning and cross dependencies.

Actually, the tolerance is needed to verify whether the input is at least 2-dimensional (in simple words, whether all input points do not overlap). Therefore removal of tolerance is not a solution, we rather need to make use of it instead.

pawelbaran commented 6 months ago

Renamed the issue from Remove redundant tolerance input from FitLine method to Apply tolerance to preliminary check in FitLine after reconsidering the problem - see original message.