BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

Geometry_Engine: Singular Value Decomposition algorithm applied to FitPlane method #3290

Closed pawelbaran closed 6 months ago

pawelbaran commented 6 months ago

Issues addressed by this PR

Closes #3287

Test files

On SharePoint

Changelog

Additional comments

pawelbaran commented 6 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 6 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
pawelbaran commented 6 months ago

@BHoMBot check required

bhombot-ci[bot] commented 6 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` There are 13 requests in the queue ahead of you.
bhombot-ci[bot] commented 6 months ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 6 months ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
FraserGreenroyd commented 6 months ago

@BHoMBot check compliance @BHoMBot check versioning

bhombot-ci[bot] commented 6 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` - check `versioning`
FraserGreenroyd commented 6 months ago

@BHoMBot check installer @BHoMBot check required

bhombot-ci[bot] commented 6 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `installer` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
bhombot-ci[bot] commented 6 months ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 6 months ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 6 months ago
The check `versioning` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 6 months ago
The check `installer` has already been run previously and recorded as a successful check. This check has not been run again at this time.
FraserGreenroyd commented 6 months ago

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

FraserGreenroyd commented 6 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 6 months ago
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.
bhombot-ci[bot] commented 6 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `ready-to-merge` There are 26 requests in the queue ahead of you.
pawelbaran commented 6 months ago

Apologies for commenting under a merged PR, but @peterjamesnugent I am afraid I have not linked the test files that I prepared. Just FYI, there is a test script covering general cases as well as edge ones that broke the original solution.

I will aggregate all test content that I prepared in the recent weeks and push in a single attempt to close out https://github.com/BHoM/BHoM_Engine/issues/3277 👍