BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

Geometry_Engine: Tolerance introduced to the check of 2-dimensionality of the input point set #3293

Closed pawelbaran closed 6 months ago

pawelbaran commented 6 months ago

Issues addressed by this PR

Closes #3288

Test files

On SharePoint

Changelog

Additional comments

pawelbaran commented 6 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 6 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
pawelbaran commented 6 months ago

@BHoMBot check required

bhombot-ci[bot] commented 6 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` There are 23 requests in the queue ahead of you.
bhombot-ci[bot] commented 6 months ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 6 months ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
pawelbaran commented 6 months ago

Thanks @peterjamesnugent!

Would it be worth adding an error message if we are going to return null?

Concerning the above question, I would rather not do that because e.g. IsCollinear is meant to return true in case of FitLine() == null, assuming that coincident points are collinear. Would that make sense to you?

FraserGreenroyd commented 6 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 6 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 9 requests in the queue ahead of you.
FraserGreenroyd commented 6 months ago

@BHoMBot check required

bhombot-ci[bot] commented 6 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` There are 1 requests in the queue ahead of you.
bhombot-ci[bot] commented 6 months ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 6 months ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
FraserGreenroyd commented 6 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 6 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `ready-to-merge` There are 6 requests in the queue ahead of you.
FraserGreenroyd commented 6 months ago

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

bhombot-ci[bot] commented 6 months ago
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.