BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

Geometry_Engine: numerical solution in IsCoplanar replaced with geometrical one #3298

Closed pawelbaran closed 5 months ago

pawelbaran commented 6 months ago

Issues addressed by this PR

Closes #2423 Closes #3294

Test files

General test files for the methods changed in this PR uploaded to SharePoint Test file for https://github.com/BHoM/BHoM_Engine/issues/2423 linked in the issue

Changelog

Additional comments

This is the last PR in the current push in Geometry_Engine 🙈

pawelbaran commented 6 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 6 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
pawelbaran commented 6 months ago

@BHoMBot check required

bhombot-ci[bot] commented 6 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
bhombot-ci[bot] commented 6 months ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 6 months ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
pawelbaran commented 5 months ago

Thanks @peterjamesnugent for the review. Updating the UTs is on my radar, to be done in sprint 6 based on https://github.com/BHoM/BHoM_Engine/issues/3277 👍

FraserGreenroyd commented 5 months ago

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

bhombot-ci[bot] commented 5 months ago
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.
FraserGreenroyd commented 5 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 5 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `ready-to-merge`