BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

Base_Engine: ThrowError(bool) makes no sense #3301

Closed FraserGreenroyd closed 6 months ago

FraserGreenroyd commented 6 months ago

The method ThrowError takes in a boolean to determine whether or not to suppress error throwing. On the face of it, this makes sense, however, when written in code, you get this situation:

ThrowError(true) - this means don't throw errors (suppress error throwing is true). ThrowError(false) - this means throw errors (suppress error throwing is false).

If you understand the code and can read it ok this makes sense but is very very unintuitive.

Therefore this should be fixed and reversed so that:

ThrowError(true) will result in errors being thrown and ThrowError(false) will turn it off.