BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

Settings_Engine: LoadSettings from file conflicts with the original method #3303

Closed FraserGreenroyd closed 6 months ago

FraserGreenroyd commented 6 months ago

I've realised that the new LoadSettings(string) has the risk of being confused with the original LoadSettings method as all inputs to the original method are optional, and the first input to both is a string so to avoid confusion, I'm going to rename the new method to be LoadSettingsFromFile instead.

Thanks @Tom-Kingstone for pointing it out just as I hit the merge on #3300 😄