search

BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

Structure_Engine: TimberSection Create method only takes Timber materials, but it should take ITImber #3308

Closed peterjamesnugent closed 5 months ago

peterjamesnugent commented 5 months ago

Description:

https://github.com/BHoM/BHoM_Engine/blob/d6c6541cb3e71c1ec63c45a61b52c26dc4591747/Structure_Engine/Create/SectionProperties/TimberSection/TimberSectionFromProfile.cs#L50 https://github.com/BHoM/BHoM_Engine/blob/d6c6541cb3e71c1ec63c45a61b52c26dc4591747/Structure_Engine/Create/SectionProperties/TimberSection/TimberRectangleSection.cs#L52

Whereas the object can take any IMaterialFragment: https://github.com/BHoM/BHoM/blob/ee776993d5a52c808b34bb747ac3209bc02ed771/Structure_oM/SectionProperties/TimberSection.cs#L41-L42

Steps to reproduce:

Use Create methods above and try to assign Glulam etc.

Expected behaviour:

ITimber materails to be assignable via the Create method.

Test file(s):