BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

Structure_Engine: Update Timber constructors to accept ITimber as inputs #3309

Closed peterjamesnugent closed 5 months ago

peterjamesnugent commented 5 months ago

NOTE: Depends on

https://github.com/BHoM/BHoM/pull/1603

Issues addressed by this PR

Closes #3308

Test files

Test script

Changelog

Additional comments

peterjamesnugent commented 5 months ago

@BHoMBot check required @BHoMBot check compliance

bhombot-ci[bot] commented 5 months ago
@peterjamesnugent to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 14 requests in the queue ahead of you.
bhombot-ci[bot] commented 5 months ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 5 months ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 5 months ago
@peterjamesnugent just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM
bhombot-ci[bot] commented 5 months ago
@peterjamesnugent just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM
IsakNaslundBh commented 5 months ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 5 months ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `unit-tests`
FraserGreenroyd commented 5 months ago

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

bhombot-ci[bot] commented 5 months ago
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.
IsakNaslundBh commented 5 months ago

@BHoMBot check required @BHoMBot check compliance

bhombot-ci[bot] commented 5 months ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
IsakNaslundBh commented 5 months ago

@BHoMBot check required @BHoMBot check compliance

bhombot-ci[bot] commented 5 months ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
bhombot-ci[bot] commented 5 months ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 5 months ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 5 months ago
The check `installer` has already been run previously and recorded as a successful check. This check has not been run again at this time.
IsakNaslundBh commented 5 months ago

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

bhombot-ci[bot] commented 5 months ago
@IsakNaslundBh I'm sorry, but I am not authorised to take that instruction from you.
bhombot-ci[bot] commented 5 months ago
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.
bhombot-ci[bot] commented 5 months ago
@peterjamesnugent just to let you know, I have provided a `check-ready-to-merge` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM