BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

Serialiser_Engine: Investigate edge case where the Serialiser_Engine is able to deserialise methods with changed method signature #3310

Open IsakNaslundBh opened 5 months ago

IsakNaslundBh commented 5 months ago

Description:

https://github.com/BHoM/BHoM_Engine/pull/3309/files shows that the Serialiser_Engien is able to deserialise and implicitly upgrade the methods even if it has a changed method signature. For the particular case, it upgrades correctly, but for the general case this could be an issue if it upgrades to something it is not meant to upgrade to. All changes to method signature should be handled explicitly in versioning and this type of upgrade by chance should not really be happening.

For the current case it might have to do with input type being changed between "Timber" and "ITimber", and the fact that we sometimes remove the leading I in the ToText method for types, but is to be investigated.

Steps to reproduce:

Expected behaviour:

Test file(s):